Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make libgmic src a git submodule instead of wget+tar extract #75

Closed
myselfhimself opened this issue Nov 4, 2020 · 2 comments
Closed

Make libgmic src a git submodule instead of wget+tar extract #75

myselfhimself opened this issue Nov 4, 2020 · 2 comments
Assignees
@myselfhimself

Comments

@myselfhimself
Copy link
Owner

Pointed out by @Czaki on pypa/cibuildwheel#329
@myselfhimself myselfhimself self-assigned this Nov 4, 2020
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule
840ffd3
@myselfhimself
Copy link
Owner Author

Done

myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (2)
40fedef
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (3)
bbc85f4
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (4)
5d86295
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (5)
8bdb313
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (7) 2.9.1
804004e
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (8)
b0af498
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (9)
ea8abb7
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (10)
fb648cf
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (11) older CImg
f7c782e
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (12) cimglist_for
3db2ea9
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (12) newer c++
1b55e64
myselfhimself added a commit that referenced this issue Nov 13, 2020
@myselfhimself
#5 #75 using gmic submodule (13)
3c4b441
@myselfhimself
Copy link
Owner Author

libgmic compiling using git submodules is really tricky instead of a single wget before, for several reasons:

  • tag-based git submodule pull needs several commands,
  • libgmic depends on two submodules and 2 unix-based make commands to zlib compress a file to generate a .h.
    I may give up on this submodules strategy.... although it seemed intellectually elegant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myselfhimself myselfhimself

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@myselfhimself