Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AbstractGenericExportMojo to fully configure GenericExporter #384

Closed
matthewadams opened this issue Apr 8, 2013 · 3 comments · Fixed by #385
Closed

Allow AbstractGenericExportMojo to fully configure GenericExporter #384

matthewadams opened this issue Apr 8, 2013 · 3 comments · Fixed by #385
Milestone

Comments

@matthewadams
Copy link
Contributor

Some configurable settings of GenericExporter are not present on AbstractGenericExportMojo. All settings that are generic (not technology-specific) should be available to enable full control.

@timowest
Copy link
Member

timowest commented Apr 9, 2013

I simplified the configuration contract a bit, since the configure + configureSpecifically division was not clear in my opinion, since both could be overridden.

Now it's just configure which can use the super.configure(exporter) call in the beginning to extend or drop it to replace the configuration logic.

@matthewadams
Copy link
Contributor Author

That was actually how I did it on my first cut, but just didn't want to
make configure(..) final. Making things final is a very serious thing. :)

On Tue, Apr 9, 2013 at 1:00 AM, Timo Westkämper notifications@github.comwrote:

I simplified the configuration contract a bit, since the configure +
configureSpecifically division was not clear in my opinion, since both
could be overridden.

Now it's just configure which can use the super.configure(exporter) call
in the beginning to extend or drop it to replace the configuration logic.


Reply to this email directly or view it on GitHubhttps://github.com//issues/384#issuecomment-16095675
.

mailto:matthew@matthewadams.me matthew@matthewadams.me
skype:matthewadams12
googletalk:matthew@matthewadams.me
http://matthewadams.me
http://www.linkedin.com/in/matthewadams

@timowest
Copy link
Member

Released in 3.1.1

@timowest timowest added this to the 3.1.1 milestone Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants