OrderSpecifier nullsFirst/nullsLast does not follow the JPQL grammar

[daniel-frank]

Using QueryDSL 3.2.1 (Maven Central) this code

c.cbo.descricao.asc().nullsLast()

serializes to

cargo.cbo.descricao is null

Looking at the source of the problem i found this code in JPQLSerializer.java(line 221)

// order by
if (!orderBy.isEmpty() && !forCountRow) {
    append(ORDER_BY);
    boolean first = true;
    for (final OrderSpecifier<?> os : orderBy) {
        if (!first) {
            append(COMMA);
        }
        handle(os.getTarget());
        if (os.getNullHandling() == OrderSpecifier.NullHandling.NullsFirst) {
            append(" is not null, ");
            handle(os.getTarget());
        } else if (os.getNullHandling() == OrderSpecifier.NullHandling.NullsLast) {
            append(" is null, ");
            handle(os.getTarget());
        }
        append(os.getOrder() == Order.ASC ? " asc" : " desc");
        first = false;
    }

Thanks in advance

[timowest]

Do you get an Exception? Which JPA provider and database are you using?

[daniel-frank]

Yup.

//Exception:
java.lang.IllegalArgumentException: An exception occurred while creating a query in EntityManager: 
Exception Description: Syntax error parsing [select trabalhadorCargo.matricula, trabalhadorCargo.trabalhador.nome, trabalhadorCargo.dataAdmissao, trabalhadorCargo.centroCusto, trabalhadorCargo.cbo, coalesce(an.valor, ?1), coalesce(i.valor, ?1), coalesce(p.valor, ?1), coalesce(s.valor, ?1)
from TrabalhadorCargo trabalhadorCargo
  left join CalculoFormula an on an.trabalhadorCargo = trabalhadorCargo and an.calculoReferencia = ?2 and an.codigo = ?3
  left join CalculoFormula i on i.trabalhadorCargo = trabalhadorCargo and i.calculoReferencia = ?2 and i.codigo = ?4
  left join CalculoFormula p on p.trabalhadorCargo = trabalhadorCargo and p.calculoReferencia = ?2 and p.codigo = ?5
  inner join CalculoFormula s on s.trabalhadorCargo = trabalhadorCargo and s.calculoReferencia = ?2 and s.codigo = ?6
where trabalhadorCargo.empresaMFP = ?7
order by trabalhadorCargo.cbo.descricao is null, trabalhadorCargo.cbo.descricao asc]. 
[797, 835]  The expression is invalid, which means it does not follow the JPQL grammar.

JPA provider: Eclipselink 2.4.2
Database: PostgreSQL 9.1

[timowest]

It appears EclipseLink supports nulls first/last directly http://java-persistence-performance.blogspot.fi/2012/05/jpql-vs-sql-have-both-with-eclipselink.html

[daniel-frank]

Exact. http://wiki.eclipse.org/EclipseLink/UserGuide/JPA/Basic_JPA_Development/Querying/JPQL

[timowest]

As both Hibernate and Eclipselink support NULLS FIRST/LAST now, they are now also directly used in Querydsl

• https://hibernate.atlassian.net/browse/HHH-465

[daniel-frank]

Ok, awesome. Any ETA?

[timowest]

I will make a new release next week. In the meantime you can use the latest snapshot from here https://oss.sonatype.org/content/repositories/snapshots/

[daniel-frank]

Appreciated, thank you for the quickly answer. QueryDSL has making a great success where I work here in Brazil.

[timowest]

Released in 3.2.2