Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport update #722

Merged
merged 17 commits into from Mar 28, 2017

Conversation

Projects
None yet
3 participants
@tekka007
Copy link
Contributor

commented Jan 5, 2017

New features:

  • Two RFM69 drivers: old (=default) driver, and refactored driver (not compatible with old driver, ATC & seq# implemented), enable using #define MY_RFM69_NEW_DRIVER on all nodes & GW.
  • Transport power down during sleep if transport-specific power pin defined: MY_XYZ_POWER_PIN
  • New mode: MY_PASSIVE_NODE - node reports passively, i.e. one-off transmission, no established uplink required, no resend, no ACK: transmissions can be undirected (no defined parent, but need for de-duplication as all repeaters will forward the message, not recommended - frequent routing tables updates if node reporting via several parents) or directed via a static parent (recommended)
  • old RFM69 driver: Implement sanity check
  • RFM95: enable MY_RFM_TCXO to use temperature controlled oscillator (if present), fixes #753
  • Uplink signal quality monitor, i.e. avg RSSI to parent: RF24 (pseudo value), RFM69, RFM95
  • transportGetSignalReport() function, reports (if implemented) RSSI, SNR, TX power level, uplink signal quality.
    Information is requested using I_SIGNAL_REPORT_REQUEST:[SELECTOR]:
    S[!]: receiving SNR at node (! from node)
    R[!]: receiving RSSI at node (! from node)
    P: TX power level %
    T: TX power level dBm
    U: uplink quality (RSSI)

Changes:

  • module specific debug: CORE, TRANSPORT, SIGNING, OTA_UPDATE, RF24, RFM69 (new driver only), RFM95 using #define MY_DEBUG_VERBOSE_XYZ
  • restructured transport-specific functions, re-organize drivers: hal/transport folder
  • smartSleep: send I_PRE_SLEEP_NOTIFICATION and I_POST_SLEEP_NOTIFICATION instead of heartbeat (payload: PRE: waiting/processing time for incoming messages until sleeping, POST: sleeping time), fixes #730
  • More robust ID requests, fixes #732

Fixes:

  • RFM95 frequency calculation: rounding artifact

@tekka007 tekka007 force-pushed the tekka007:transportUpdate branch 16 times, most recently from 84f01a4 to c172d9b Jan 5, 2017

@tekka007 tekka007 added this to the 2.2.0 milestone Jan 15, 2017

@tekka007 tekka007 force-pushed the tekka007:transportUpdate branch from c172d9b to 9670678 Jan 15, 2017

@tekka007 tekka007 force-pushed the tekka007:transportUpdate branch from 9670678 to fe9fab0 Jan 15, 2017

@tekka007 tekka007 modified the milestones: 2.2.0, 2.1.1 Jan 16, 2017

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Feb 1, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Feb 1, 2017

Git commit message(s) look good!

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Feb 1, 2017

Will evaluate git discipline...

@tekka007 tekka007 force-pushed the tekka007:transportUpdate branch from 2ebe424 to d27b32f Mar 27, 2017

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 27, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 27, 2017

Git commit message(s) look good!

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 27, 2017

I found warnings (compiler or Doxygen related) in the MySensors core library when building the core library verification sketches. Please rebuild your changes locally with all warnings enabled in the Arduino IDE and make sure it compiles cleanly and resubmit your changes. You do not need to resolve warnings that are unrelated to your change.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoLibPR/950/
Compiler warnings exist in the Subproject Builds marked with yellow. Click the yellow dot and then on "Arduino/AVR warnings" to review the warnings reported.
Doxygen warnings are reported here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoLibPR/950/warnings14Result
A member of the MySensors core team can retrigger a build on this exact commit by telling me "jenkins, build this please".
But remember that I will only listen if you name me with a capital 'J'.
If the PR is updated I will rebuild it automatically.

@tekka007 tekka007 force-pushed the tekka007:transportUpdate branch from d27b32f to f649996 Mar 27, 2017

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 27, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 27, 2017

Git commit message(s) look good!

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 27, 2017

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@tekka007

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2017

Jenkins, build examples please

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 27, 2017

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoPR/673/

@tekka007 tekka007 force-pushed the tekka007:transportUpdate branch 6 times, most recently from 38aae8c to ee253ff Mar 28, 2017

@tekka007 tekka007 force-pushed the tekka007:transportUpdate branch from ee253ff to 417cfad Mar 28, 2017

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 28, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 28, 2017

Git commit message(s) look good!

@tekka007

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2017

Jenkins, build examples please

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 28, 2017

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoPR/678/

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 28, 2017

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@henrikekblad henrikekblad merged commit b132a8a into mysensors:development Mar 28, 2017

4 checks passed

Gitler Git commit message(s) look good!
Details
Jenkins (examples) Examples built successfully.
Details
Jenkins (test sketches) Core tests successful.
Details
clahub All contributors have signed the Contributor License Agreement.
Details

@tekka007 tekka007 deleted the tekka007:transportUpdate branch Mar 28, 2017

@trlafleur trlafleur referenced this pull request Mar 28, 2017

Closed

RFM95 with TCXO #753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.