Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport update #722

Merged
merged 17 commits into from Mar 28, 2017
Merged

Conversation

tekka007
Copy link
Contributor

@tekka007 tekka007 commented Jan 5, 2017

New features:

  • Two RFM69 drivers: old (=default) driver, and refactored driver (not compatible with old driver, ATC & seq# implemented), enable using #define MY_RFM69_NEW_DRIVER on all nodes & GW.
  • Transport power down during sleep if transport-specific power pin defined: MY_XYZ_POWER_PIN
  • New mode: MY_PASSIVE_NODE - node reports passively, i.e. one-off transmission, no established uplink required, no resend, no ACK: transmissions can be undirected (no defined parent, but need for de-duplication as all repeaters will forward the message, not recommended - frequent routing tables updates if node reporting via several parents) or directed via a static parent (recommended)
  • old RFM69 driver: Implement sanity check
  • RFM95: enable MY_RFM_TCXO to use temperature controlled oscillator (if present), fixes RFM95 with TCXO  #753
  • Uplink signal quality monitor, i.e. avg RSSI to parent: RF24 (pseudo value), RFM69, RFM95
  • transportGetSignalReport() function, reports (if implemented) RSSI, SNR, TX power level, uplink signal quality.
    Information is requested using I_SIGNAL_REPORT_REQUEST:[SELECTOR]:
    S[!]: receiving SNR at node (! from node)
    R[!]: receiving RSSI at node (! from node)
    P: TX power level %
    T: TX power level dBm
    U: uplink quality (RSSI)

Changes:

  • module specific debug: CORE, TRANSPORT, SIGNING, OTA_UPDATE, RF24, RFM69 (new driver only), RFM95 using #define MY_DEBUG_VERBOSE_XYZ
  • restructured transport-specific functions, re-organize drivers: hal/transport folder
  • smartSleep: send I_PRE_SLEEP_NOTIFICATION and I_POST_SLEEP_NOTIFICATION instead of heartbeat (payload: PRE: waiting/processing time for incoming messages until sleeping, POST: sleeping time), fixes Smartsleep: Notification about going to sleep instead of heartbeat #730
  • More robust ID requests, fixes Making id request more robust #732

Fixes:

  • RFM95 frequency calculation: rounding artifact

@tekka007 tekka007 force-pushed the transportUpdate branch 16 times, most recently from 84f01a4 to c172d9b Compare January 12, 2017 18:16
@tekka007 tekka007 added this to the 2.2.0 milestone Jan 15, 2017
@mysensors-jenkins
Copy link

Will evaluate git discipline...

@mysensors-jenkins
Copy link

Git commit message(s) look good!

@mysensors-jenkins
Copy link

Will evaluate git discipline...

@mysensors-jenkins
Copy link

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoPR/672/

@mysensors-jenkins
Copy link

Will evaluate git discipline...

@mysensors-jenkins
Copy link

Git commit message(s) look good!

@mysensors-jenkins
Copy link

I found warnings (compiler or Doxygen related) in the MySensors core library when building the core library verification sketches. Please rebuild your changes locally with all warnings enabled in the Arduino IDE and make sure it compiles cleanly and resubmit your changes. You do not need to resolve warnings that are unrelated to your change.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoLibPR/950/
Compiler warnings exist in the Subproject Builds marked with yellow. Click the yellow dot and then on "Arduino/AVR warnings" to review the warnings reported.
Doxygen warnings are reported here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoLibPR/950/warnings14Result
A member of the MySensors core team can retrigger a build on this exact commit by telling me "jenkins, build this please".
But remember that I will only listen if you name me with a capital 'J'.
If the PR is updated I will rebuild it automatically.

@mysensors-jenkins
Copy link

Will evaluate git discipline...

@mysensors-jenkins
Copy link

Git commit message(s) look good!

@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@tekka007
Copy link
Contributor Author

Jenkins, build examples please

@mysensors-jenkins
Copy link

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoPR/673/

@tekka007 tekka007 force-pushed the transportUpdate branch 6 times, most recently from 38aae8c to ee253ff Compare March 28, 2017 12:49
@mysensors-jenkins
Copy link

Will evaluate git discipline...

@mysensors-jenkins
Copy link

Git commit message(s) look good!

@tekka007
Copy link
Contributor Author

Jenkins, build examples please

@mysensors-jenkins
Copy link

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoPR/678/

@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants