Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT Client Retain Feature #793

Merged
merged 1 commit into from Mar 21, 2017

Conversation

Projects
None yet
3 participants
@mannkind
Copy link
Contributor

commented Mar 20, 2017

Some controllers do not have the ability (or have a limited ability) to restore state after restarting.

This optional feature flag will allow the MQTT gateway client to publish very specific messages (C_SET, and C_INTERNAL w/type I_BATTERY_LEVEL) with the retain flag set.

The current behavior should not be impacted.

--

I've been using the bool retain = ... code for nearly a year now; it has worked quite well for me. I thought I'd put it behind a feature flag and see if it'd be useful to other people.

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 20, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 20, 2017

Git commit message(s) look good!

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 20, 2017

I found warnings (compiler or Doxygen related) in the MySensors core library when building the core library verification sketches. Please rebuild your changes locally with all warnings enabled in the Arduino IDE and make sure it compiles cleanly and resubmit your changes. You do not need to resolve warnings that are unrelated to your change.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoLibPR/923/
Compiler warnings exist in the Subproject Builds marked with yellow. Click the yellow dot and then on "Arduino/AVR warnings" to review the warnings reported.
Doxygen warnings are reported here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoLibPR/923/warnings14Result
A member of the MySensors core team can retrigger a build on this exact commit by telling me "jenkins, build this please".
But remember that I will only listen if you name me with a capital 'J'.
If the PR is updated I will rebuild it automatically.

@henrikekblad

This comment has been minimized.

Copy link
Member

commented Mar 21, 2017

@mannkind
Thanks for the PR,

To fix the last warning, just add the new define inside the #if DOXYGEN section at the bottom of the MyConfig.h file.

MQTT Client Retain Feature
Optionally allow MQTT client to publish specific messages with
the retain flag set.

default/current behavior should not be impacted.
@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 21, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 21, 2017

Git commit message(s) look good!

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Mar 21, 2017

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@henrikekblad henrikekblad merged commit ef42b3b into mysensors:development Mar 21, 2017

3 checks passed

Gitler Git commit message(s) look good!
Details
Jenkins (test sketches) Core tests successful.
Details
clahub All contributors have signed the Contributor License Agreement.
Details

@mannkind mannkind deleted the mannkind:MqttRetain branch Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.