Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rasperry pi hwGetentropy() #856

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
4 participants
@d00616
Copy link
Contributor

commented May 21, 2017

Now its compatible to Linux distributions without "linux/random.h". Fixes #854

@mysensors-jenkins

This comment has been minimized.

Copy link

commented May 21, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Copy link

commented May 21, 2017

Git commit message(s) look good!

@tekka007 tekka007 added bug RPi labels May 21, 2017

@tekka007 tekka007 added this to the 2.2.0 milestone May 21, 2017

@tekka007 tekka007 requested a review from marceloaqno May 21, 2017

@d00616

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2017

I will change the code to keep the FP open. This speeds up hwGetentropy()

@d00616 d00616 force-pushed the d00616:fix_rapsi_random branch from 3943ece to 064e0f8 May 22, 2017

@mysensors-jenkins

This comment has been minimized.

Copy link

commented May 22, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Copy link

commented May 22, 2017

Git commit message(s) look good!

@mysensors-jenkins

This comment has been minimized.

Copy link

commented May 22, 2017

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@marceloaqno
Copy link
Member

left a comment

Some minor fixes:
Rename RandomFp to randomFp.
For the fread to return the number of bytes read it needs to be:

fread(__buffer, 1, __length, randomFp)

@d00616 d00616 force-pushed the d00616:fix_rapsi_random branch from 064e0f8 to 81c5428 May 23, 2017

@mysensors-jenkins

This comment has been minimized.

Copy link

commented May 23, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Copy link

commented May 23, 2017

Git commit message(s) look good!

@d00616

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2017

@marceloaqno Thank you. I have changed it.

@mysensors-jenkins

This comment has been minimized.

Copy link

commented May 23, 2017

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@marceloaqno marceloaqno merged commit aeceb0b into mysensors:development May 23, 2017

3 checks passed

Gitler Git commit message(s) look good!
Details
Jenkins (test sketches) Core tests successful.
Details
clahub All contributors have signed the Contributor License Agreement.
Details

@d00616 d00616 deleted the d00616:fix_rapsi_random branch Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.