Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rasperry pi hwGetentropy() #856

Merged
merged 1 commit into from May 23, 2017
Merged

Fix rasperry pi hwGetentropy() #856

merged 1 commit into from May 23, 2017

Conversation

d00616
Copy link
Contributor

@d00616 d00616 commented May 21, 2017 •
edited

Now its compatible to Linux distributions without "linux/random.h". Fixes #854

@mysensors-jenkins
Copy link

Will evaluate git discipline...

@mysensors-jenkins
Copy link

Git commit message(s) look good!

@tekka007 tekka007 added this to the 2.2.0 milestone May 21, 2017
@d00616 d00616 mentioned this pull request May 21, 2017
Closed
@tekka007 tekka007 requested a review from marceloaqno May 21, 2017 19:18
@d00616
Copy link
Contributor Author

d00616 commented May 22, 2017

I will change the code to keep the FP open. This speeds up hwGetentropy()

@mysensors-jenkins
Copy link

Will evaluate git discipline...

@mysensors-jenkins
Copy link

Git commit message(s) look good!

@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

marceloaqno
marceloaqno requested changes May 23, 2017
View reviewed changes
Copy link
Member

@marceloaqno marceloaqno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor fixes:
Rename RandomFp to randomFp.
For the fread to return the number of bytes read it needs to be:

fread(__buffer, 1, __length, randomFp)

@mysensors-jenkins
Copy link

Will evaluate git discipline...

@mysensors-jenkins
Copy link

Git commit message(s) look good!

@d00616
Copy link
Contributor Author

d00616 commented May 23, 2017

@marceloaqno Thank you. I have changed it.

@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@marceloaqno marceloaqno merged commit aeceb0b into mysensors:development May 23, 2017
@d00616 d00616 deleted the fix_rapsi_random branch August 29, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marceloaqno marceloaqno marceloaqno approved these changes

Assignees
No one assigned
Labels
bug RPi
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d00616 @mysensors-jenkins @marceloaqno @tekka007