Memory Optimization: Add NO_MODULE_POWER_MANAGER to remove all traces of the power manager #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the power manager Currently, each Child and the NodeManager itself hold a pointer to the power manager, even if no power manager is ever needed or desired. This patch adds a NO_MODULE_POWER_MANAGER flag, which will not compile the power manager and also remove all code and variables related to the power manager. This saves at lease one pointer per child plus one pointer in the NodeManager. So with 10 sensors, at least 22 bytes of SRAM and some flash are saved.
|
Merging it but I will probably create a different PR for changing NO_MODULE_POWER_MANAGER into something like DISABLE_POWER_MANAGER to avoid confusion between modules (associated to sensors) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each Child and the NodeManager itself hold a pointer to the power manager, even if no power manager is ever needed or desired. This patch adds a NO_MODULE_POWER_MANAGER flag, which will not compile the power manager and also remove all code and variables related to the power manager. This saves at lease one pointer per child plus one pointer in the NodeManager. So with 10 sensors, at least 22 bytes of SRAM and some flash are saved.