[Excel Analyzer] handle chartsheets

Don't error and dump internal structure of RubyXL gem parsing into the metadata field
mysociety · Jan 22, 2024 · f87ec29 · f87ec29
1 parent 089c34a
commit f87ec29
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/gems/excel_analyzer/lib/excel_analyzer/metadata.rb b/gems/excel_analyzer/lib/excel_analyzer/metadata.rb
@@ -40,6 +40,8 @@ def external_links
 
     def hidden_columns
       workbook.worksheets.sum do |sheet|
+        next 0 unless sheet.is_a?(RubyXL::Worksheet)
+
         hidden_columns = []
 
         sheet.cols.compact.select(&:hidden).each do |col_range|
@@ -55,6 +57,8 @@ def hidden_columns
 
     def hidden_rows
       workbook.worksheets.sum do |sheet|
+        next 0 unless sheet.is_a?(RubyXL::Worksheet)
+
         hidden_rows = sheet.sheet_data.rows.compact.select(&:hidden)
 
         hidden_rows.count do |row|

diff --git a/gems/excel_analyzer/spec/excel_analyzer/probe_spec.rb b/gems/excel_analyzer/spec/excel_analyzer/probe_spec.rb
@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe ExcelAnalyzer::Probe do
+  include ExcelAnalyzer::Probe
+
+  it "does not error if workbook has chartsheets" do
+    xlsx = File.open(File.join(__dir__, "../fixtures/chartsheet.xlsx"))
+    expect(probe(xlsx)).to be_a(Hash)
+  end
+end
+
diff --git a/gems/excel_analyzer/spec/fixtures/chartsheet.xlsx b/gems/excel_analyzer/spec/fixtures/chartsheet.xlsx