Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoIP-database-contrib isn't installable #5040

Closed
gbp opened this issue Jan 8, 2019 · 3 comments · Fixed by #5319
Closed

GeoIP-database-contrib isn't installable #5040

gbp opened this issue Jan 8, 2019 · 3 comments · Fixed by #5319
Assignees
Labels
awaiting-review bug Breaks expected functionality f:framework

Comments

@gbp
Copy link
Member

gbp commented Jan 8, 2019

Due to deprecation of the GeoLite Legacy databases we can't run CI builds or build Vagrant boxes.

@lizconlan: with some additional digging, it looks like the underlying problem is that during the Jan 7th maintenance window, it looks like MaxMind have gone ahead and removed the v1 files from their site so the packages installer chokes while attempting the download; geoipupdate looks as though it should fetch the v2 files so that's a partial solution

however...
the v2 files are a different format which the geoip gem we rely on does not understand them https://github.com/cjheath/geoip#featuresproblems

we've had problems in the past where the geoip database was out of date and misidentifying users as being in the US (I think what happened was an IP block or so was transferred between ISPs, possibly due to takeovers - e.g. PlusNet - etc) so keeping it up to date is definitely something we need to keep in mind #2520

For a quick fix to get builds working again we could be to switch to geoip-database, this works as the CSV are included in the package

There seems to be some newer GeoIp replacements listed in cjheath/geoip#75 so we should look at migrating to those at some point - possible the one provided by MaxMind once we drop Ruby <2.3 #4541 #4542 #4842

@gbp gbp changed the title GeoIp GeoIP-database-contrib isn't installable Jan 8, 2019
@gbp gbp added bug Breaks expected functionality framework-improvement f:framework labels Jan 8, 2019
lizconlan added a commit that referenced this issue Jan 8, 2019
The geoip-database-contrib package attempts to download the legacy data
files which have now been removed from MaxMind's web servers.

The latest geoip-database package supplies the November 2018 version of
these files which should be safe to use until we can find a way to
ingest the v2 format files.

Connects to #5040
@garethrees garethrees added this to Contender in mysociety/alaveteli May 7, 2019
@garethrees
Copy link
Member

Try to fix in #5229

@garethrees
Copy link
Member

http://www.rubygeocoder.com/ might be worth a look here.

@gbp
Copy link
Member Author

gbp commented Aug 2, 2019

http://www.rubygeocoder.com/ might be worth a look here.

That's normally my go to gem for geocoding and... TIL it can use MaxMind with local downloaded DB see: https://github.com/alexreisner/geocoder/blob/master/test/unit/lookups/maxmind_local_test.rb evens provides rake tasks for downloading them too.

Looks like a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review bug Breaks expected functionality f:framework
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants