Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace close and anonymise with independent account closure actions #7646

Closed
garethrees opened this issue Mar 17, 2023 · 1 comment · Fixed by #7727
Closed

Replace close and anonymise with independent account closure actions #7646

garethrees opened this issue Mar 17, 2023 · 1 comment · Fixed by #7727
Assignees
Labels
easier-admin Make issues easier to resolve enhancement Adds new functionality f:admin x:uk

Comments

@garethrees
Copy link
Member

garethrees commented Mar 17, 2023

Requires #7611.

Instead of a single "close and anonymise" action, we should make the set of actions more composable. For example, a user may only want their account closed rather than anonymised.

Screenshot 2023-03-17 at 14 57 22

Each option should document what the action does inline in the UI. Might want to fold the specifics in a <details> tag if it starts getting too long.

For close and anonymise we currently state:

This is disabled for banned users as the email address must be preserved to enforce the ban. First remove the ban text and then close and anonymise the account.

I think this is still true. We should allow the #close and #anonymise options when the user is banned, but disable #erase, as that's the one that will now remove the account email address.

When an account gets closed, we should ensure that no email gets sent to it (#4603 is likely relevant here). We'll need to be careful about this becoming a rabbit hole. If it starts getting complicated, the easiest solution might be a callback along the lines of before_action { return false if @recipient.closed? } in the mailer methods.

Note that #5052 (comment) still requires the User#close_and_anonymise method – this issue is just to replace the admin UI options.

@garethrees garethrees added x:uk easier-admin Make issues easier to resolve enhancement Adds new functionality f:admin labels Mar 17, 2023
@garethrees garethrees added this to the Reduce Admin Burden milestone Apr 3, 2023
@alexander-griffen alexander-griffen self-assigned this Apr 11, 2023
@gbp gbp self-assigned this Apr 11, 2023
@JenMysoc JenMysoc unassigned gbp May 9, 2023
@JenMysoc
Copy link
Member

JenMysoc commented May 22, 2023

Next step

  • Merge the PR and close this off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easier-admin Make issues easier to resolve enhancement Adds new functionality f:admin x:uk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants