Feature/further request event fixes #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall looks good, as far as my understanding of the (very involved!) issues here go. My comments are all quite minor - it'd be good to deal with them, but I'm happy for this to be merged. |
Update test expectations and add further test to explicitly show that we want the described status from a status update to be propagated to a preceding response, as well as being filled in in the status update itself (which is mostly to deal with the case where there isn't a preceding response). Make those changes to calculate_event_states
Make sure that admin edits changing the described state of an info request are reflected in the latest_status and status values of info request events so that the info requests are retrieved correctly in status-based searches.
Set to 'waiting_response' on creation, to match the displayed state.
Add some notes on the logic and expectations around InfoRequest.described_state and calculate_status and InfoRequestEvent.described_state and calculated_state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix for #460, b24ad7c, does fix the problem of request events ending up with an incorrect latest_status value when a status update is made, and so turning up in the wrong results sets for status-based searches. But it has the disadvantage that setting the calculated state on the new 'status_update' event stopped the state propagating backwards to any preceding response. So searches that combined a 'variety:response' and status filter would have been missing requests. This pull request includes a fix that still allows the state to propagate backwards to any recent response, adds a similar fix for admin edits, and includes a script to fix up the event history of any requests that are currently returning an incorrect value for 'latest_status'.