Add a new helper to return the contents of an asset file #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizconlan
force-pushed
the
4148-fix-sprockets-error
branch
3 times, most recently
from
116d1f9
to
6e1dc6b
Compare
garethrees
reviewed
Aug 8, 2017
app/helpers/application_helper.rb
Outdated
| @@ -78,6 +78,11 @@ def admin_date(date) | |||
| return "#{exact_date} (#{ago_text})" | |||
| end | |||
|
|
|||
| def read_asset_file(asset_name) | |||
| assets = Rails.application.assets_manifest.find_sources(asset_name) | |||
| assets.first.force_encoding('utf-8') if assets.first | |||
There was a problem hiding this comment.
I think it should raise an exception if it can't be found, otherwise this would silently fail.
garethrees
requested changes
Aug 9, 2017
app/helpers/application_helper.rb
Outdated
| if assets.first | ||
| assets.first.force_encoding('utf-8') | ||
| else | ||
| raise(Sprockets::FileNotFound, |
There was a problem hiding this comment.
Always omit parentheses for Methods that have "keyword" status in Ruby:
https://github.com/bbatsov/ruby-style-guide#method-invocation-parens
With Sprockets 3.x and Rails 4.2 and up, the default setting in
production for `config.assets.compile` is false which means that
`application.assets` is not populated when we attempt to access it to
read the asset file contents.
* Adds a new helper method to:
- handle the call to the sprockets method
`applications.assets_manifest.find_sources()` which returns an
Enumerator of the contents of found files instead of the original
method's String or Nil
- forces the content to UTF-8 to avoid possible string concatenation
errors
lizconlan
force-pushed
the
4148-fix-sprockets-error
branch
from
f947e10
to
082ffdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #4148
Fix inspired by rails/sprockets-rails#237 (comment)
(and the immediate followups).
Placed in a helper wrapper to allow us to force UTF-8 and handle the minor faff of checking whether the Enumerator actually contains anything without a bunch of extra stuff to the template.
After deploying, we may need to clear zip file caches for attempted downloads as I suspect it's cached an HTML file containing the File Not Found message