Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RuboCop failures warnings rather than errors #5921

Merged
merged 1 commit into from Oct 15, 2020

Conversation

garethrees
Copy link
Member

Failures for this check are not always technical errors – they're more a
case of requiring human judgement as to whether to fix or not.

Documentation reference: https://github.com/reviewdog/action-rubocop/blob/d3161530d1ad5da4bac484302ecddcba02d186e6/README.md#level

Failures for this check are not always technical errors – they're more a
case of requiring human judgement as to whether to fix or not.

Documentation reference: https://github.com/reviewdog/action-rubocop/blob/d3161530d1ad5da4bac484302ecddcba02d186e6/README.md#level
@gbp gbp self-requested a review October 15, 2020 08:22
@gbp gbp self-assigned this Oct 15, 2020
Copy link
Member

@gbp gbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work:

Screen Shot 2020-10-15 at 10 24 28
Screen Shot 2020-10-15 at 10 24 13

@gbp gbp assigned garethrees and unassigned gbp Oct 15, 2020
@mysociety-pusher mysociety-pusher merged commit 74b98a2 into develop Oct 15, 2020
@mysociety-pusher mysociety-pusher deleted the rubocop-check-level branch October 15, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants