Excel analyzer improvements #8102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move metadata parsing into its own class, this saves passing around the ZIP file to individual methods.
Lets have keys and method alphabetical.
Extract workbook handling into a helper as we're going to end up querying the workbook more.
Unable to create a fixture file with data model embedded by these are stored as `xl/model/item.data` files.
Can be a good indication along with external links of hidden data.
Instead of parsing XML ourselves use this gem which will also allow us to look into cell contents.
Instead of storing if present we can store how many matches are present.
We don't care about blank cells in hidden rows and columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Excel analyzer improvements.
Why was this needed?
Better detection of hidden data in Excel spreadsheets.
[skip changelog]