[#7255] Add category notes #8178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
7255-category-notes
branch
from
440a3fb
to
e5c625c
Compare
Add method to the return the uppermost root category for a given child category. This will be useful for finding the root in the `current_klass` helper in `Admin::CategoriesController`. Needed in order to not required the `model_type` parameter for all controller actions.
We don't have a show view so lets redirect to the edit form. This is needed as we will be adding notes to categories and after a concrete note is saved it redirects to the notable show action.
Update the `#all_notes` method to check if the current class is Taggable before combining tagged notes.
This will be used in the admin UI when creating Notes for a given Category. We're not yet showing the public link as this depends on the type of category being used.
Will be used to allow rich text non-note styled content on the public category pages.
gbp
force-pushed
the
7809-add-actiontext-to-notes
branch
from
a244cb1
to
ddaff31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #7255
What does this do?
Add category notes
Why was this needed?
So we can create topic pages to display info requests in given categories (via tags). And render notes and other "unstyled" rich text content on the page.
Screenshots