[#8190] Fix logout issues #8195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the configuration of the i18n locale gems and storing the locale in the user session into separate actions. This will allow us to skip storing the session in controller actions where this isn't desirable.
There is conflict when calling `render html: ...` which we do in AttachmentController#show_as_html and updating the session which is causing the session to be reset. This change prevents the session from being updated in the before action hook. Fixes #8190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #8190
What does this do?
Fix logout issues
Why was this needed?
To fix unexpected behaviour and retain user browser sessions.
Implementation notes
Not 100% sure of the reason for this issue. I can only replicate this on WDTK and the Alaveteli staging environment. Running in production elsewhere works fine so I guess this could be due to how we have Apache/Varnish configured? /cc @sagepe
[skip changelog]