[#7812] Allow requests to be browsed by tag #8197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
7812-browse-request-category
branch
3 times, most recently
from
07d109b
to
f370a7b
Compare
Remove unused double and there is no reason to load the raw emails.
Extract setup into before action hook. This will be reused in a new list by tag action.
gbp
force-pushed
the
7812-browse-request-category
branch
from
f370a7b
to
36ccb76
Compare
|
Have forced push some updates so the existing form filters now keep the current tag. This gives us URLs in the form of |
gbp
force-pushed
the
7812-browse-request-category
branch
from
36ccb76
to
5b54100
Compare
gbp
force-pushed
the
7812-browse-request-category
branch
from
5b54100
to
2d819a3
Compare
Remove routes for "all" and "recent" views. The "recent" view already is redirected in the main `list` action to the "all" view. The "all" view should really be the default for the `list` action as currently the `/list` endpoint will show no requests because there is no view is selected.
Having access to the results here will allow us to check for the number of results before rendering.
gbp
force-pushed
the
7812-browse-request-category
branch
from
2d819a3
to
50dbd0a
Compare
|
This all looks great to me! Would it be easy to change the heading to just the category title?
|
gbp
force-pushed
the
7812-browse-request-category
branch
from
b5f92fb
to
4bde041
Compare
Allow users to view requests by tag. In the tag belongs to a category then, load the category and render a different title.
Render any category notes and it's rich text body.
gbp
force-pushed
the
7812-browse-request-category
branch
from
4bde041
to
bb16fb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #7812
What does this do?
Allow requests to be browsed by tag
Why was this needed?
So we can view tagged requests and make topic pages.
Screenshots