Stop slashes breaking CSV report downloads.

Removes slashes from category names as:

Forward slash stops a file being created.
Backward slash stops a file being retrieved.

Co-Authored-By: M Somerville <matthew@mysociety.org>

CHANGELOG.md

@@ -36,6 +36,7 @@
         - Fix removal of cached opengraph photos.
         - Do not email inactive body comment users. #3587
         - Look up organizational domain in DMARC checking. #3603
+        - Stop slash in category name breaking csv download #3642
     - Admin improvements:
         - Assignees of reports are now visible in admin reports list and report edit pages.
         - Enable per-category hint customisation.

perllib/FixMyStreet/Reporting.pm

@@ -101,7 +101,7 @@ has filename => ( is => 'rw', isa => Str, lazy => 1, default => sub {
         $self->on_updates ? ('updates') : (),
         map {
             my $value = $where{$_};
-            (my $nosp = $value || '') =~ s/ /-/g;
+            (my $nosp = $value || '') =~ s/[ \/\\]/-/g;
             (defined $value and length $value) ? ($_, $nosp) : ()
         } sort keys %where
 });

t/app/controller/dashboard.t

@@ -271,6 +271,12 @@ FixMyStreet::override_config {
         $mech->content_contains('Report ID');
     };
 
+    subtest 'export CSV with slash in category name' => sub {
+        $mech->create_contact_ok(body_id => $body->id, category => "This/That", email => "this\@example.org");
+        my $token = 'access_token=' . $counciluser->id . '-1234567890abcdefgh';
+        $mech->get_ok("/dashboard?export=2&$token&category=This/That");
+    };
+
     subtest 'view status page' => sub {
         # Simulate a partly done file
         my $f = Path::Tiny->tempfile(SUFFIX => '.csv-part', DIR => path($UPLOAD_DIR, 'dashboard_csv', $counciluser->id));