[Open311] Consistent protected field ordering.

Without this sort, the protected fields could be pushed on in any order.
If more than one of those protected fields then had the same sort order,
they could be sorted in that pushed-on order, which could change between
runs.

CHANGELOG.md

@@ -33,6 +33,8 @@
     - Development improvements:
         - Include failure count in send report error output, #3316
         - Sort output in export script. #3323
+    - Open311 improvements:
+        - Consistent protected field ordering.
     - Security:
         - Increase minimum password length to eight.
 

perllib/Open311/PopulateServiceList.pm

@@ -251,7 +251,8 @@ sub _add_meta_to_contact {
         @{ $meta_data->{attributes} };
 
     # and then add back in any protected fields that we don't fetch
-    push @meta, values %$protected;
+    # sort by code for consistent sort order later on
+    push @meta, sort { $a->{code} cmp $b->{code} } values %$protected;
 
     # turn the data into something a bit more friendly to use
     @meta =