Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nearby can't be filtered by $c->cobrand->problems #1289

Closed
joseph-t-martin opened this issue Nov 30, 2015 · 0 comments
Closed

Nearby can't be filtered by $c->cobrand->problems #1289

joseph-t-martin opened this issue Nov 30, 2015 · 0 comments
Assignees

Comments

@joseph-t-martin
Copy link

Nearby.pm doesn't filter using $c->cobrand->problems so if you have a custom query in the custom cobrand file It will incorrectly return the results on the /around page

dracos added a commit that referenced this issue Dec 4, 2015
5c79337 simplified a bit too far, as Nearby and My could only then
in a particular cobrand potentially restrict to a particular body,
not any other criteria. Switch to more generic updates_restriction
and problems_restriction to allow cobrands more flexibility.

Make sure a few tests delete their bodies fully so that new tests
pass when run as part of the suite.

Fixes #1289.
@dracos dracos self-assigned this Dec 4, 2015
dracos added a commit that referenced this issue Dec 15, 2015
5c79337 simplified a bit too far, as after then a particular cobrand
could in Nearby and My only filter reports to a particular body, not
any other criteria. To fix this, introduce more generic functions in
the default cobrand to allow more flexibility.

Make sure a few tests delete their bodies fully so that new tests
pass when run as part of the suite.

Fixes #1289.
@dracos dracos removed the Reviewing label Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants