Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IE7/8 workarounds and remove IE6 ones #1356

Closed
zarino opened this issue Mar 11, 2016 · 1 comment
Closed

Improve IE7/8 workarounds and remove IE6 ones #1356

zarino opened this issue Mar 11, 2016 · 1 comment
Labels

Comments

@zarino
Copy link
Member

zarino commented Mar 11, 2016

I just spotted a workaround for IE6 in position_map.js:

function position_map_box() {
    var $html = $('html');
    if ($html.hasClass('ie6')) {
        
    } else {
        
    }
}

And a quick search for ie6 in the *.scss files returns a surprising number of hits.

In the last 6 months (10th September–10th March), 19 people used IE6 to visit fixmystreet.com. That’s less than 0.01% of visitors.

Do we still need these workarounds?

@dracos
Copy link
Member

dracos commented Mar 11, 2016

Yes, I'd be happy to drop the IE6 things if also a little bit of work was put into improving IE7/8, only a few niggles but they're quite obvious (e.g. button background missing, navbar background missing, though the latter of those could be 'fixed' somewhat by #1350), and do have some thousands of sessions. Perhaps also checking which bits of IE7 workarounds are still needed (there's hardly any IE8 ones).

@dracos dracos added the Design label Mar 15, 2016
@dracos dracos changed the title Remove IE6 workarounds Improve IE7/8 workarounds and remove IE6 ones Mar 15, 2016
@dracos dracos added the Backlog label May 24, 2016
@dracos dracos closed this as completed Jun 20, 2016
@dracos dracos removed the Backlog label Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants