Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle attribute external_id (fms_id) as a special case in Open311 send-reports #329

Closed
davewhiteland opened this issue Sep 26, 2012 · 2 comments
Assignees

Comments

@davewhiteland
Copy link
Contributor

Proposed change: when sending a problem report over Open311 that has an attribute['fms_id'] , automatically populate that attribute with the report's id.

FMS-endpoint expects the FMS report ID to be provided in an attribute called external_id (although there's a strong case for this being fms_id -- see mysociety/fms-endpoint#19 so there's no risk of a nameclash with some other use of external_id).

Currently we're doing this by switching on the cobrand (fixmybarangay) which means FMS-endpoint doesn't quite work as expected with default FMS installs.

@davewhiteland
Copy link
Contributor Author

If this change is implemented, then FMS-endpoint can provide the attribute in its service discovery responses (see mysociety/fms-endpoint#20 ) -- then FMS + FMS-endpoint would exchange FMS ids nicely, automatically.

@dracos
Copy link
Member

dracos commented Aug 24, 2016

Dealt with, as fixmystreet_id (or overrideable id field name in PopulateServiceList), by #1499.

@dracos dracos closed this as completed Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants