Include status change line in update emails using auto response templates. #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4967 +/- ##
==========================================
+ Coverage 82.57% 82.79% +0.22%
==========================================
Files 393 393
Lines 30697 31248 +551
Branches 4861 5009 +148
==========================================
+ Hits 25349 25873 +524
- Misses 3897 3908 +11
- Partials 1451 1467 +16 ☔ View full report in Codecov by Sentry. |
neprune
force-pushed
the
fix-state-change-text-not-in-response-template-updates
branch
2 times, most recently
from
fb1168d
to
76a1059
Compare
davea
reviewed
May 28, 2024
perllib/FixMyStreet/Script/Alerts.pm
Outdated
| @@ -133,6 +133,9 @@ sub send_alert_type { | |||
| $row->{item_text_original} = $row->{item_text}; | |||
| $row->{item_text} = $row->{item_text} ? $row->{item_text} . "\n\n" . $update : | |||
| $update; | |||
| if ($row->{item_private_email_text} && $report->contact->get_extra_metadata('type', '') ne 'waste') { | |||
There was a problem hiding this comment.
Just curious if this could be $report->cobrand_data ne 'waste' instead?
There was a problem hiding this comment.
Aha yes, appears so
templates. Except for waste categories. #4901
neprune
force-pushed
the
fix-state-change-text-not-in-response-template-updates
branch
from
f0f41d0
to
44674bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for waste categories.
closes #4901