Customisable defect types #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
issues/forcouncils/160-customisable-defect-types
branch
from
29c15e7
to
cdcedf3
Compare
dracos
requested changes
Mar 21, 2017
There was a problem hiding this comment.
Haven't had time to give a thorough looking at, but as this only affects Oxfordshire I think I'm happy with it enough for it for now. One possible change, and I'd like the commits squashed/tidied (it's not clear what a defect type is/is for at present, I think :) ).
| } | ||
| $rs->search($attrs, { | ||
| order_by => 'name', | ||
| join => { 'contact_defect_types' => 'contact' }, |
There was a problem hiding this comment.
I think this function is always called with a category, so doesn't really matter, but we don't want to do this join if $category is not set, I imagine.
pezholio
force-pushed
the
issues/forcouncils/160-customisable-defect-types
branch
from
cdcedf3
to
515362a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/mysociety/fixmystreetforcouncils/issues/160