cobrand hook to deny access to pages #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2092 +/- ##
==========================================
- Coverage 78.7% 78.09% -0.61%
==========================================
Files 182 178 -4
Lines 11738 11493 -245
Branches 2181 2113 -68
==========================================
- Hits 9238 8976 -262
- Misses 1738 1798 +60
+ Partials 762 719 -43
Continue to review full report at Codecov.
|
struan
force-pushed
the
issues/commercial/1017-superuser-login-only
branch
3 times, most recently
from
40e1dcd
to
35f5a97
Compare
dracos
requested changes
Apr 27, 2018
| @@ -39,6 +39,7 @@ sub auto : Private { | |||
|
|
|||
| # decide which cobrand this request should use | |||
| $c->setup_request(); | |||
| $c->detach('/auth/redirect', []) if $c->cobrand->call_hook(check_login_disallowed => $c); | |||
There was a problem hiding this comment.
You don't need to pass in $c here, it's available as $self->{c} in a cobrand during a web request.
t/app/controller/root.t
Outdated
|
|
||
| $mech->get('/'); | ||
| is $mech->status, 302, 'disallowed page issues a redirect'; | ||
| is $mech->res->headers->header('location'), 'http://localhost/auth?r=auth', 'redirects to auth page'; |
There was a problem hiding this comment.
Redirecting to /auth?r=auth doesn't feel right; if you fetched the front page, shouldn't it have been /auth?r=?
dracos
approved these changes
Jun 18, 2018
Add a check in the root controller `auto` to a cobrand hook that denies access if it returns true. This goes here so that cobrands and users are set up, which is not the case for `check_login_required`. Used to do things like deny site access unless the user is a superuser.
struan
force-pushed
the
issues/commercial/1017-superuser-login-only
branch
from
af8dfc9
to
85ae59f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check in the root controller
autoto a cobrand hook that deniesaccess if it returns true. This goes here so that cobrands and users are
set up, which is not the case for
check_login_required. Used to dothings like deny site access unless the user is a superuser.