Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message on reports closed to updates. #2163

Merged
merged 1 commit into from Jun 21, 2018

Conversation

dracos
Copy link
Member

@dracos dracos commented Jun 18, 2018

To do:

  • (post-deploy) [UK] Add running of process-inactive-reports to crontab.

screen shot 2018-06-20 at 17 23 47

Fixes https://github.com/mysociety/fixmystreet-commercial/issues/875

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #2163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2163   +/-   ##
=======================================
  Coverage   78.84%   78.84%           
=======================================
  Files         182      182           
  Lines       11754    11754           
  Branches     2190     2189    -1     
=======================================
  Hits         9268     9268           
  Misses       1721     1721           
  Partials      765      765
Impacted Files Coverage Δ
perllib/Open311/GetServiceRequestUpdates.pm 73.56% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e48a4a...896a117. Read the comment docs.

@dracos dracos force-pushed the issues/commercial/875-old-reports branch from 368b7e9 to 56e1c6c Compare June 19, 2018 09:52
Copy link
Member

@struan struan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A test might be nice :)

@dracos dracos force-pushed the issues/commercial/875-old-reports branch 2 times, most recently from aacacb7 to a2caa80 Compare June 19, 2018 15:24
@zarino
Copy link
Member

zarino commented Jun 20, 2018

I think this is fine for what it is, design-wise. Something about the "make…" immediately after the statement feels abrupt to me. I felt like I expected it to be worded "…closed to updates – but you can make a new…"

@dracos dracos force-pushed the issues/commercial/875-old-reports branch from a2caa80 to 896a117 Compare June 21, 2018 11:30
@dracos dracos merged commit 896a117 into master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants