-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Northamptonshire] restrict title to 120 characters #2451
[Northamptonshire] restrict title to 120 characters #2451
Conversation
dab5600
to
cc70303
Compare
Codecov Report
@@ Coverage Diff @@
## master #2451 +/- ##
==========================================
+ Coverage 81.06% 81.07% +<.01%
==========================================
Files 196 196
Lines 12639 12642 +3
Branches 2349 2350 +1
==========================================
+ Hits 10246 10249 +3
+ Misses 1604 1603 -1
- Partials 789 790 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2451 +/- ##
==========================================
+ Coverage 81.18% 81.18% +<.01%
==========================================
Files 197 197
Lines 12632 12635 +3
Branches 2344 2345 +1
==========================================
+ Hits 10255 10258 +3
+ Misses 1594 1593 -1
- Partials 783 784 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comma issue; could we put maxlength on the actual input to save the user only finding out it's too long when they hit a button? (In fact, maxlength is on textarea too, so we should do this on detail too!)
web/cobrands/fixmystreet-uk-councils/council_validation_rules.js
Outdated
Show resolved
Hide resolved
01676ab
to
3115db7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine; ideally the maxlength
should be output in the HTML also if someone has come to /report/new
directly (the server presumably can know the location + body at that point, or at least only on the cobrand always would be simpler presumably).
3115db7
to
5164b9e
Compare
Prevent people from using very long titles. Fixes mysociety/societyworks#1344
If a field has a maximum length set in the javascript validation then add a maxlength attribute so the user doesn't have to wait till submission to find out about it.
5164b9e
to
355f891
Compare
Prevent people from using very long titles.
Fixes mysociety/fixmystreet-commercial#1344
Please check the following:
Please check the contributing docs, and describe your pull request here.
Screenshots or GIF animations (using e.g. LICEcap) may be helpful.
Please include any issues that are fixed, using "fixes" or "closes" so that
they are auto-closed when the PR is merged.
Thanks for contributing!