Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bexley changes #2481

Merged
merged 6 commits into from May 17, 2019
Merged

Bexley changes #2481

merged 6 commits into from May 17, 2019

Conversation

dracos
Copy link
Member

@dracos dracos commented May 16, 2019

[skip changelog]
This changes which categories display which assets, and shows the asset ID on the pin/sidebar.

@dracos dracos requested a review from struan May 16, 2019 16:37
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #2481 into bexley will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           bexley    #2481      +/-   ##
==========================================
- Coverage   81.43%   81.42%   -0.01%     
==========================================
  Files         201      201              
  Lines       12710    12710              
  Branches     2345     2345              
==========================================
- Hits        10350    10349       -1     
  Misses       1548     1548              
- Partials      812      813       +1
Impacted Files Coverage Δ
perllib/Utils.pm 97.97% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b04af3...a4371f8. Read the comment docs.

Copy link
Member

@struan struan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚥

Copy link
Member

@struan struan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just slight UX thing.

web/cobrands/bexley/js.js Show resolved Hide resolved
@dracos dracos requested a review from struan May 17, 2019 11:05
Copy link
Member

@struan struan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants