Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have duplicate suggestion and assets coexist better #2589

Merged
merged 2 commits into from Aug 8, 2019

Conversation

dracos
Copy link
Member

@dracos dracos commented Aug 7, 2019

@dracos dracos requested a review from davea August 7, 2019 09:09
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #2589 into master will increase coverage by 14.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2589       +/-   ##
===========================================
+ Coverage   54.86%   69.11%   +14.24%     
===========================================
  Files         210      203        -7     
  Lines       13123    12681      -442     
  Branches     2424     2323      -101     
===========================================
+ Hits         7200     8764     +1564     
+ Misses       5097     3179     -1918     
+ Partials      826      738       -88
Impacted Files Coverage Δ
...lib/FixMyStreet/SendReport/Email/SingleBodyOnly.pm 14.28% <0%> (-85.72%) ⬇️
perllib/FixMyStreet/Cobrand/Zurich.pm 2.85% <0%> (-84.49%) ⬇️
perllib/FixMyStreet/SendReport/Zurich.pm 5.26% <0%> (-84.22%) ⬇️
perllib/FixMyStreet/Integrations/ExorRDI.pm 9.72% <0%> (-80.56%) ⬇️
perllib/FixMyStreet/Cobrand/Bexley.pm 4.54% <0%> (-78.79%) ⬇️
perllib/FixMyStreet/Cobrand/Bromley.pm 15.38% <0%> (-67.59%) ⬇️
perllib/FixMyStreet/Geocode/Address.pm 27.27% <0%> (-63.64%) ⬇️
perllib/Utils/Email.pm 29.62% <0%> (-62.97%) ⬇️
...ib/FixMyStreet/App/Controller/Admin/ExorDefects.pm 24.32% <0%> (-62.17%) ⬇️
perllib/FixMyStreet/Geocode/Google.pm 8.57% <0%> (-60.01%) ⬇️
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d1414...ea7c5b5. Read the comment docs.

Copy link
Member

@davea davea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise this looks fine, and a nice and simple change in the end!

I think the "zoom in to pick a light" text should be hidden when duplicates are shown though:

image

@dracos
Copy link
Member Author

dracos commented Aug 7, 2019

"I think the "zoom in to pick a light" text should be hidden when duplicates are shown though:" - yes that is fixed by one part of #2588 :)

@davea
Copy link
Member

davea commented Aug 7, 2019

yes that is fixed by one part of #2588 :)

Excellent!

@dracos dracos merged commit ea7c5b5 into master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants