Allow contact send method to be unset always. #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a body was set to Open311, and a contact set to Email, it was impossible to unset the contact's send method and set an Open311 code, because it would always demaned a valid email address.
dracos
force-pushed
the
allow-undevolving
branch
from
22d2bb3
to
0d7d04f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2622 +/- ##
=======================================
Coverage 82.29% 82.29%
=======================================
Files 215 215
Lines 13497 13497
Branches 2504 2504
=======================================
Hits 11108 11108
Misses 1525 1525
Partials 864 864
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a body was set to Open311, and a contact set to Email, it was
impossible to unset the contact's send method and set an Open311
code, because it would always demaned a valid email address.