New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that Vagrant box packages are kept updated #2886
Conversation
feed359
to
3f225db
Compare
Codecov Report
@@ Coverage Diff @@
## master #2886 +/- ##
=========================================
+ Coverage 83.1% 83.1% +<.01%
=========================================
Files 238 238
Lines 15062 15062
Branches 2803 2803
=========================================
+ Hits 12517 12518 +1
Misses 1641 1641
+ Partials 904 903 -1
Continue to review full report at Codecov.
|
3f225db
to
96c10df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "fallback" is the mySociety specific packages file (e.g. installs soap-lite)- I wonder if it should be generic it falls back to?
How about this - just default to If that's OK, I'll tidy up the commits and rebase against master. |
Yep, looks good, thanks! |
This adds a script, `bin/install_packages`, that will install packages listed in versions of `conf/packages*` and calls it from the bootstrap script in a way appropriate to the environment it is being run under. This should ensure that, for example, changes to dependencies will be applied to Vagrant machines in-between tagged releases. The default packages file used will be `packages.generic`.
For local testing, we'll now treat a box named `fms-local` as if it was the Vagrant Cloud box.
b8d5d20
to
2c9bed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐬
This adds a script,
bin/install_packages
, that will install packageslisted in versions of
conf/packages*
and calls it from the bootstrapscript in a way appropriate to the environment it is being run under.
This should ensure that, for example, changes to dependencies will be
applied to Vagrant machines in-between tagged releases.
Please check the following: