Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Vagrant box packages are kept updated #2886

Merged
merged 2 commits into from Mar 3, 2020

Conversation

sagepe
Copy link
Member

@sagepe sagepe commented Feb 12, 2020

This adds a script, bin/install_packages, that will install packages
listed in versions of conf/packages* and calls it from the bootstrap
script in a way appropriate to the environment it is being run under.

This should ensure that, for example, changes to dependencies will be
applied to Vagrant machines in-between tagged releases.

Please check the following:

  • Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
  • Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #2886 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2886      +/-   ##
=========================================
+ Coverage    83.1%   83.1%   +<.01%     
=========================================
  Files         238     238              
  Lines       15062   15062              
  Branches     2803    2803              
=========================================
+ Hits        12517   12518       +1     
  Misses       1641    1641              
+ Partials      904     903       -1
Impacted Files Coverage Δ
perllib/Utils.pm 98.98% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65ce0e...2c9bed2. Read the comment docs.

@sagepe sagepe changed the title [script/bootstrap] Ensure that Debian packages are installed Ensure that Vagrant box packages are kept updated Feb 18, 2020
@sagepe sagepe marked this pull request as ready for review February 18, 2020 11:20
@sagepe sagepe self-assigned this Feb 18, 2020
@sagepe sagepe requested a review from dracos February 18, 2020 11:20
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "fallback" is the mySociety specific packages file (e.g. installs soap-lite)- I wonder if it should be generic it falls back to?

@sagepe
Copy link
Member Author

sagepe commented Mar 2, 2020

How about this - just default to packages.generic unless we think we' in Docker.

If that's OK, I'll tidy up the commits and rebase against master.

@dracos
Copy link
Member

dracos commented Mar 2, 2020

Yep, looks good, thanks!

This adds a script, `bin/install_packages`, that will install packages
listed in versions of `conf/packages*` and calls it from the bootstrap
script in a way appropriate to the environment it is being run under.

This should ensure that, for example, changes to dependencies will be
applied to Vagrant machines in-between tagged releases.

The default packages file used will be `packages.generic`.
For local testing, we'll now treat a box named `fms-local` as if it
was the Vagrant Cloud box.
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐬

@sagepe sagepe merged commit 2c9bed2 into master Mar 3, 2020
@github-pages github-pages bot temporarily deployed to github-pages March 3, 2020 11:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants