Add photo field to inspector form

[chrismytton]

This adds a photo upload field to the inspector form.

Fixes #2902
Related to #2901

[codecov]

Codecov Report

Merging #2965 into master will decrease coverage by 0.01%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #2965      +/-   ##
==========================================
- Coverage   83.50%   83.48%   -0.02%     
==========================================
  Files         250      250              
  Lines       15616    15620       +4     
  Branches     2921     2922       +1     
==========================================
+ Hits        13040    13041       +1     
- Misses       1655     1657       +2     
- Partials      921      922       +1     

Impacted Files	Coverage Δ
perllib/FixMyStreet/App/Controller/Report.pm	87.46% <25.00%> (-0.78%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994093c...ae687e6. Read the comment docs.

[dracos]

A few small suggestions is all.

[chrismytton]

While demo-ing the inspector tool on staging @dracos noticed that this change actually breaks the offline "save submitted form offline and submit to server when back online" functionality. Looks like that doesn't handle multipart forms correctly (it's assuming it's just a foo=1&bar=2 string).

Also worth noting that formData() is not available in service workers in Safari.

[dracos]

Other than the thing you've just mentioned, changes all look good - I think there's another partial you could have extracted in report/new/form_report.html?

[davea]

The Dropzone widget doesn't load if the report is loaded from the sidebar (e.g. on /reports or /my/planned):

If you hit reload or visit the report URL directly it's fine though:

(guessing it's not running the Dropzone JS after AJAX loading the report content)

Submitting the form with a photo offline on iOS also results in a "Safari cannot open the page because your iPhone is not connected to the internet" message, which I've not yet been able to track down the cause of. It looks like it's trying to do a POST to /report/<id> instead of being handled by the JS/service worker.

[dracos]

That looks to be the fix for the dropzone issue, certainly. This has been round long enough, so I'd say let's tidy/merge even if there is an iOS issue? I can't see what it would be, though :-/ Could hide form from iOS users if people start using it in anger, and/or revisit if/as we work on more full offline support, I guess.

[davea]

Agreed with @dracos that we should ship this sooner rather than later. However I don't think we can do that in the current state with the iOS bug as that's a bit of a showstopper for any staff affected. Removing the fields for offline iOS users seems like a good compromise for now.

[davea]

The most recent two commits should sort the iOS issue 👍 @dracos do they look ok?

[dracos]

One unneeded commit (if I've understood it right) is all! Watch out for touchscreen desktop macs I guess ;-/

Open a new ticket about getting photo upload working offline I guess. Did you get any useful info in debugging it as to why it wasn't being handled by the service worker?

And I guess another ticket for having an offline-only Dropzone that could display the same as normal usage but only set the client input rather than try and upload async.

Can't review my own code

[dracos]

One bit I think would be better in the other commit, but meh :) Phewee.

[dracos]

Pedantic, but I guess this should be in the following commit, as in this commit, offline support is just broken for everything because the changes in the following commit have not yet been made.