Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move admin index stats to stats page #2982

Merged
merged 3 commits into from Apr 28, 2020

Conversation

dracos
Copy link
Member

@dracos dracos commented Apr 24, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #2982 into master will increase coverage by 0.00%.
The diff coverage is 96.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2982   +/-   ##
=======================================
  Coverage   82.89%   82.90%           
=======================================
  Files         242      242           
  Lines       15239    15247    +8     
  Branches     2832     2833    +1     
=======================================
+ Hits        12632    12640    +8     
  Misses       1693     1693           
  Partials      914      914           
Impacted Files Coverage Δ
perllib/FixMyStreet/App/Controller/Status.pm 28.00% <0.00%> (ø)
perllib/FixMyStreet/DB/ResultSet/Problem.pm 96.07% <ø> (ø)
perllib/FixMyStreet/App/Controller/Admin.pm 77.37% <100.00%> (-1.25%) ⬇️
perllib/FixMyStreet/App/Controller/Admin/Stats.pm 95.71% <100.00%> (+2.09%) ⬆️
perllib/FixMyStreet/Cobrand/UKCouncils.pm 89.51% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f70ef9f...24124fd. Read the comment docs.

These stats can take a while to generate, and we don't want to slow
down people mostly coming to the admin index to do something else.
@dracos dracos force-pushed the move-admin-index-stats-to-stats-page branch from dcdb2b3 to 24124fd Compare April 24, 2020 19:18
@dracos dracos requested a review from chrismytton April 25, 2020 16:24
Copy link
Member

@chrismytton chrismytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@dracos dracos merged commit 4edf5a8 into master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants