Upgrade jQuery #3017
Merged
Upgrade jQuery #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
from
bc96d85
to
8900bb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3017 +/- ##
===========================================
- Coverage 82.55% 56.23% -26.33%
===========================================
Files 324 310 -14
Lines 21810 21051 -759
Branches 3283 3130 -153
===========================================
- Hits 18006 11837 -6169
- Misses 2757 8279 +5522
+ Partials 1047 935 -112
Continue to review full report at Codecov.
|
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
from
8900bb7
to
1547727
Compare
zarino
approved these changes
May 6, 2020
There was a problem hiding this comment.
Looks good! Tests pass, and I’ve checked it out and poked around locally. I wonder whether we should test the core javascript functionality in IE9 on BrowserStack, just to be sure that nothing we’ve done has affected support there? Seems unlikely, but you never know.
Nice to have stripped out all that IE6–8 cruft! And a more modern version of jQuery too. Lovely.
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
from
1547727
to
d2e4b6b
Compare
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
2 times, most recently
from
bf47d47
to
a1e6881
Compare
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
from
a1e6881
to
7bece02
Compare
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
10 times, most recently
from
e802f8b
to
986e531
Compare
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
from
986e531
to
ed950ee
Compare
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
from
ed950ee
to
a6191bb
Compare
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
2 times, most recently
from
53c6d0d
to
f72db98
Compare
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
2 times, most recently
from
86ac4c8
to
79a2179
Compare
Include some tests for the drawer opening.
Remove use of jQuery UI spinner entirely, and cut down the included jQuery UI CSS/JS to only the used autocomplete library.
dracos
force-pushed
the
remove-ie8-upgrade-jquery
branch
from
79a2179
to
ba6788c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin.
I followed the jQuery upgrade instructions, and ran migrate alongside each upgrade, and fixed the obvious things. Not sure we can know whether everything has been caught.
I manually fixed issues in fancybox, we should do a comparator of similar more modern things and pick the nicest/smallest.
(diff is low because lots of the click() -> on('click') changes are within parts of the code not tested.)