Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard report CSV export. #3026

Merged
merged 1 commit into from May 7, 2020
Merged

Fix dashboard report CSV export. #3026

merged 1 commit into from May 7, 2020

Conversation

dracos
Copy link
Member

@dracos dracos commented May 7, 2020

No description provided.

@dracos dracos requested a review from davea May 7, 2020 11:49
The change to join in e160541 did not include a collapse that the
previous prefetch was doing, so multiple rows per result were being
returned.
@dracos dracos force-pushed the fix-dashboard-report-csv branch from c7219cd to 5ce552a Compare May 7, 2020 13:41
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #3026 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3026   +/-   ##
=======================================
  Coverage   83.04%   83.04%           
=======================================
  Files         246      246           
  Lines       15379    15379           
  Branches     2872     2872           
=======================================
  Hits        12771    12771           
  Misses       1695     1695           
  Partials      913      913           
Impacted Files Coverage Δ
perllib/FixMyStreet/Cobrand/Bexley.pm 85.71% <ø> (ø)
perllib/FixMyStreet/Cobrand/TfL.pm 85.12% <ø> (ø)
perllib/FixMyStreet/DB/ResultSet/Contact.pm 100.00% <ø> (ø)
perllib/FixMyStreet/App/Controller/Admin/Bodies.pm 96.45% <100.00%> (ø)
perllib/FixMyStreet/App/Controller/Dashboard.pm 90.49% <100.00%> (ø)
perllib/FixMyStreet/Cobrand/Default.pm 86.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfabb3c...5ce552a. Read the comment docs.

@dracos dracos merged commit 6fad0a9 into master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants