Fix for multiple categories with same name in different group set #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3029 +/- ##
==========================================
+ Coverage 83.08% 83.13% +0.04%
==========================================
Files 246 246
Lines 15440 15440
Branches 2887 2882 -5
==========================================
+ Hits 12829 12836 +7
+ Misses 1695 1690 -5
+ Partials 916 914 -2
Continue to review full report at Codecov.
|
dracos
force-pushed
the
he-still-bit-buggy-grr
branch
from
3aed507
to
48790c9
Compare
davea
approved these changes
May 12, 2020
dracos
force-pushed
the
he-still-bit-buggy-grr
branch
from
48790c9
to
2e97a81
Compare
dracos
force-pushed
the
he-still-bit-buggy-grr
branch
from
2e97a81
to
78ba186
Compare
When compiling the reporting category dropdown, only one instance of each value was used. But if a value appears twice, from two different bodies, in different groups, it would then not appear in all the groups it would be expected to. Make sure we update the list of groups of the category if we come across another with the same value.
dracos
force-pushed
the
he-still-bit-buggy-grr
branch
from
78ba186
to
9018344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start off making sure everything is using
->groupsconsistently, why not, then add a tiny bit to reporting so that if two bodies have a contact with the same name but in different groups, one set of groups isn't lost (spotted with Highways England but could theoretically happen elsewhere).Hopefully fixes https://github.com/mysociety/fixmystreet-commercial/issues/1854.