New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fms.com] add toggle between aerial and roads maps #3041
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3041 +/- ##
==========================================
- Coverage 83.27% 83.26% -0.01%
==========================================
Files 248 248
Lines 15561 15564 +3
Branches 2905 2906 +1
==========================================
+ Hits 12959 12960 +1
Misses 1677 1677
- Partials 925 927 +2
Continue to review full report at Codecov.
|
See https://github.com/mysociety/fixmystreet-commercial/issues/1870 for details |
67e9c68
to
defbbe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @dracos would you mind checking the non-JS commit please?
defbbe1
to
d23452c
Compare
Reviewed; then made some changes to bring the Bing URLs up to date, add attribution for the aerial layer, move it all to the base Bing so it can have this as well, and got it so the toggle works on report pages, and so MasterMap-based maps work. @struan Could you review my commits? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment. I would approve but I can only comment as it's my PR :(
[% ELSE %] | ||
<a class="" id="map_layer_toggle" href="[% c.uri_with( { aerial => 1 } ) %]">[% loc('Aerial') %]</a> | ||
<a id="map_layer_toggle" href="[% c.uri_with( { aerial => 1 } ) %]">[% loc('Aerial') %]</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing is that the link colours for this on e.g. Peterborough end up being dark blue on black so I suspect some CSS munging needs to happen.
Co-authored-by: Dave Arter <davea@mysociety.org> Co-authored-by: Matthew Somerville <matthew@mysociety.org>
2040b84
to
009c424
Compare
Adds a button to the map controls on FMS.com that toggles between the roads and aerial views:
[skip changelog]