Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update-schema constraint check on Postgres 12 #3043

Merged
merged 1 commit into from May 27, 2020
Merged

Conversation

davea
Copy link
Member

@davea davea commented May 26, 2020

pg_constraint.consrc has been removed in Postgres 12, and this is the recommended replacement.

@davea davea force-pushed the postgres-12-fix branch 2 times, most recently from f3358d4 to 8ef005b Compare May 26, 2020 13:43
@davea davea requested a review from chrismytton May 26, 2020 13:45
Copy link
Member

@chrismytton chrismytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @davea 🎉 I've been meaning to open an issue about this, but you've saved me the trouble!

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #3043 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3043      +/-   ##
==========================================
- Coverage   83.08%   83.07%   -0.02%     
==========================================
  Files         246      246              
  Lines       15440    15429      -11     
  Branches     2887     2886       -1     
==========================================
- Hits        12829    12818      -11     
  Misses       1695     1695              
  Partials      916      916              
Impacted Files Coverage Δ
perllib/Open311/PostServiceRequestUpdates.pm 90.16% <0.00%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e723a...7b7e00c. Read the comment docs.

pg_constraint.consrc has been removed in Postgres 12, and this is the recommended replacement.
See https://www.postgresql.org/docs/12/release-12.html
@davea davea merged commit 7b7e00c into master May 27, 2020
@github-pages github-pages bot temporarily deployed to github-pages May 27, 2020 09:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants