Add Open Location Codes support to search box.

[dracos]

No description provided.

[codecov]

Codecov Report

Merging #3047 into master will decrease coverage by 22.93%.
The diff coverage is 6.25%.

@@             Coverage Diff             @@
##           master    #3047       +/-   ##
===========================================
- Coverage   83.14%   60.21%   -22.94%     
===========================================
  Files         246      245        -1     
  Lines       15430    15426        -4     
  Branches     2879     2881        +2     
===========================================
- Hits        12830     9289     -3541     
- Misses       1689     5108     +3419     
- Partials      911     1029      +118     

Impacted Files	Coverage Δ
perllib/FixMyStreet/App/Controller/Location.pm	39.62% <6.25%> (-42.60%)	⬇️
perllib/FixMyStreet/DB/Result/AdminLog.pm	8.16% <0.00%> (-87.76%)	⬇️
perllib/FixMyStreet/App/Controller/Admin/Roles.pm	16.36% <0.00%> (-81.82%)	⬇️
...ib/FixMyStreet/DB/Result/ModerationOriginalData.pm	10.38% <0.00%> (-81.82%)	⬇️
.../FixMyStreet/App/Controller/Admin/ManifestTheme.pm	18.18% <0.00%> (-81.82%)	⬇️
perllib/FixMyStreet/App/Controller/Auth/Profile.pm	16.94% <0.00%> (-81.36%)	⬇️
...erllib/FixMyStreet/App/Controller/Questionnaire.pm	11.45% <0.00%> (-80.92%)	⬇️
perllib/FixMyStreet/App/Controller/Admin/States.pm	13.72% <0.00%> (-78.44%)	⬇️
perllib/FixMyStreet/App/Controller/Auth/Phone.pm	14.58% <0.00%> (-77.09%)	⬇️
...ib/FixMyStreet/App/Controller/Admin/DefectTypes.pm	15.09% <0.00%> (-75.48%)	⬇️
... and 102 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8f7ef...abc63a8. Read the comment docs.

[chrismytton]

This is nifty! Didn't realise adding support for plus codes would be so straightforward 🙂

I tried testing this with a random plus code from Google Maps, but it seems to mostly show short plus codes which don't work with this? For Waverley it's XR26+Q2 Edinburgh. Would be nice if those worked as well. But I don't think that should block this from being merged!

[dracos]

Bit annoying they don't show you the full plus code as well (which for that one is 9C7RXR26+Q2).

To make it simpler to share, one can provide a plus code relative to another base and then only give the string for the base rather than its code. Then to reverse you geocode the string and take the nearest "XR26+Q2" to that. So in this case "Edinburgh" is "9C7RXR36+" and so you then get the full code from that. It means if geocoders give different results for the same string, you could conceivably get different results, so they recommend using smaller neighbourhoods that are less likely to be different (but presumably also less likely to be found at all?!). https://github.com/google/open-location-code/wiki/Guidance-for-shortening-codes has a bit more.

The library I've added does also handle shortening/expanding, apart from the actual geocoding part. When I have a mo, I'll look at adding that, I guess it'll have to call the external geocoder, take the first result and hope that it's right.

[dracos]

Actually having written that down, it seemed quite straightforward, so have done that now too, in a new commit :)

[chrismytton]

🧭