New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fixmystreet.com] Add option for recaptcha. #3050
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3050 +/- ##
=======================================
Coverage 83.13% 83.14%
=======================================
Files 246 246
Lines 15430 15451 +21
Branches 2879 2886 +7
=======================================
+ Hits 12827 12846 +19
Misses 1690 1690
- Partials 913 915 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looking good!
Would it be possible to add a test to check that the <div class="g-recaptcha" />
element is on the page when the user's IP is non-GB?
Can we also add some documentation for RECAPTCHA
config? I tried to get this working but wasn't sure what config I needed or where to get it from?
Would also be good to add a changelog entry for this 🙂
Oh and there are quite a few red crosses in the checks section. Would be good to reduce those a bit! |
We are getting spam submissions of e.g. alert subscribe form, which causes people to get a confirmation email.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
This shows a recaptcha to logged out users from non-UK IP addresses on alert and report/update forms. For https://github.com/mysociety/sysadmin/issues/1302.