Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hackney] Custom domain for email envelope #3100

Merged
merged 2 commits into from Jul 3, 2020

Conversation

davea
Copy link
Member

@davea davea commented Jul 2, 2020

Adds cobrand hook for setting domain of VERP emails, enables this for Hackney using a cobrand feature.

@davea davea requested a review from dracos July 2, 2020 16:18
@davea davea changed the base branch from master to hackney-reviewed July 2, 2020 16:18
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vworp

@dracos
Copy link
Member

dracos commented Jul 2, 2020

(well, vworp apart from the test failures)

@davea davea force-pushed the hackney-custom-email-domain branch from a5fe368 to f4b5a62 Compare July 2, 2020 20:14
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #3100 into hackney-reviewed will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           hackney-reviewed    #3100   +/-   ##
=================================================
  Coverage             83.21%   83.22%           
=================================================
  Files                   247      247           
  Lines                 15588    15593    +5     
  Branches               2917     2917           
=================================================
+ Hits                  12972    12977    +5     
  Misses                 1681     1681           
  Partials                935      935           
Impacted Files Coverage Δ
perllib/FixMyStreet/Cobrand/Hackney.pm 58.66% <100.00%> (+1.13%) ⬆️
perllib/FixMyStreet/Email.pm 83.13% <100.00%> (+0.20%) ⬆️
perllib/FixMyStreet/Script/Alerts.pm 90.50% <100.00%> (ø)
perllib/FixMyStreet/SendReport/Email.pm 87.30% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e96deac...f4b5a62. Read the comment docs.

@davea davea merged commit f4b5a62 into hackney-reviewed Jul 3, 2020
@davea davea mentioned this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants