Fix duplicate asset selection message #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3101 +/- ##
=======================================
Coverage 83.21% 83.21%
=======================================
Files 247 247
Lines 15593 15593
Branches 2917 2917
=======================================
Hits 12976 12976
Misses 1681 1681
Partials 936 936 Continue to review full report at Codecov.
|
davea
approved these changes
Jul 5, 2020
If we create one category_meta_message for each category, removing when not relevant, then duplicat suggestion showing leads to duplicate messages because the layer is still relevant, just not visible, and so the old layer message is not removed. Instead, repurpose the ID of any existing category_meta_message, so there is only ever one in existence.
dracos
force-pushed
the
fix-duplicate-asset-selection-message
branch
from
5768cc0
to
d8245e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/mysociety/fixmystreet-commercial/issues/1920
And default as I found another type of street light not covered when I did #3070