Improve moderation diff display in few small ways #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3105 +/- ##
==========================================
- Coverage 83.26% 83.25% -0.02%
==========================================
Files 248 248
Lines 15559 15561 +2
Branches 2909 2911 +2
==========================================
Hits 12955 12955
Misses 1676 1676
- Partials 928 930 +2
Continue to review full report at Codecov.
|
As string_diff is used in hash values, it must always return something, otherwise you could end up with e.g. category => 'extra'.
This is a current full list of extra keys that could be set on a report that could confuse the moderation diff display.
dracos
force-pushed
the
fix-moderation-diff-display
branch
from
bbed7d1
to
1425244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2837