Centralise update creation to include fields. #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3111 +/- ##
==========================================
+ Coverage 83.39% 83.42% +0.02%
==========================================
Files 248 248
Lines 15571 15574 +3
Branches 2907 2906 -1
==========================================
+ Hits 12986 12992 +6
Misses 1660 1660
+ Partials 925 922 -3
Continue to review full report at Codecov.
|
struan
approved these changes
Jul 14, 2020
| @@ -206,16 +206,12 @@ sub submit_standard : Private { | |||
| $update = $c->model('DB::Comment')->new( | |||
| { | |||
| problem => $problem, | |||
| name => $problem->name, | |||
There was a problem hiding this comment.
On the off chance they've used a different name subsequent to making the report removing this will change the behaviour. I'm not sure it's worth being concerned about though.
There was a problem hiding this comment.
Yeah, I spotted that, then I thought might be better anyway to use the name currently associated with the account filling it in at the time it's filled in 👍
Given the user, we can infer the name if not provided, and the extra data if a staff user. We can also provide defaults for various other fields. Always have superuser take precedence over from_body.
dracos
force-pushed
the
record-body-update-everywhere
branch
from
82436e3
to
67823bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the user, we can infer the name if not provided, and the extra
data if a staff user. We can also provide defaults for various other
fields. Always have superuser take precedence over from_body.