Spot user set on update not at object creation. #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in 67823bc create the necessary metadata at the creation of a Comment object, but if the user is not included at that point but later (as is done by the normal public update flow), then it would not be created. Wrap the user accessor so we can make sure it is set.
Codecov Report
@@ Coverage Diff @@
## master #3123 +/- ##
=======================================
Coverage 83.42% 83.42%
=======================================
Files 248 248
Lines 15574 15574
Branches 2906 2906
=======================================
Hits 12992 12992
Misses 1660 1660
Partials 922 922
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in 67823bc create the necessary metadata at the creation
of a Comment object, but if the user is not included at that point but
later (as is done by the normal public update flow), then it would not
be created. Wrap the user accessor so we can make sure it is set.
[skip changelog]