Fix number of asset changing confusions #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
force-pushed
the
asset-changing-confusion
branch
from
4b659c6
to
89eacad
Compare
Codecov Report
@@ Coverage Diff @@
## master #3157 +/- ##
=======================================
Coverage 83.55% 83.55%
=======================================
Files 250 250
Lines 15722 15722
Branches 2939 2939
=======================================
Hits 13137 13137
Misses 1652 1652
Partials 933 933 Continue to review full report at Codecov.
|
If multiple layers are being shown (e.g. Peterborough trees) then the number of visible layers could go 1 -> 2 -> 3 -> 2, and this code would get confused and reshow the marker pin even though an asset had been selected.
If a new asset layer is shown before an old one is removed, the removal could cause the newly selected asset to be unselected, leaving visibly an asset selected but nothing recorded as being selected behind the scenes.
Otherwise, if you switch category and the new asset layer is added before the old is removed, the old (still visible) layer asset found would fire but change the meta message of the new layer.
dracos
force-pushed
the
asset-changing-confusion
branch
from
89eacad
to
51252c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see these issues on live, go to https://report.peterborough.gov.uk/report/new?longitude=-0.247059&latitude=52.556479 - click middle of St Margarets Road then select Street Lighting, then Trees, then Street Lighting, then Trees. You'll see there are now two green pins (fixed by 80d47db and 919cb2b) and it says "You can pick a light from the map" (fixed by 4b659c6).
Then click a different tree asset (up to the left there are plenty) and change category to Street lighting, you'll see there are now two selected assets (fixed by 2f7ce01).
Fixes https://github.com/mysociety/fixmystreet-commercial/issues/1888