New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Search tips" message when there are no location search results #3180
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3180 +/- ##
=======================================
Coverage 83.66% 83.66%
=======================================
Files 251 251
Lines 15744 15745 +1
Branches 2942 2942
=======================================
+ Hits 13172 13173 +1
Misses 1639 1639
Partials 933 933
Continue to review full report at Codecov.
|
6ef1cad
to
d27204f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; couple of tiny suggested changes.
f00abe5
to
486ccea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩
UK cobrands now display UK-specific postcode/address search tips, when the geocoder returns no results. This should hopefully help people tweak their search, to return a better result next time. The tips are based on findings from a study we ran on geocoder misses across all UK cobrands over March, April, May, and June 2020.
The "error" output in our new `.search-help__header` element begins and ends with whitespace. The test really shouldn’t care about whitespace at the start and end of HTML tags, so this commit makes page_errors trim whitespace from the errors it passes to the tests. Also adds `.search-help__header` as a location to find page errors!
486ccea
to
f63e2fe
Compare
Improvements to the message you get when your location search returns no results (usually because you’ve made a spelling mistake, or have used too ambiguous a street name), on fixmystreet.com and the UK council cobrands.
I’ve included a customised version for each cobrand, to match the layout of their respective homepages, eg:
The easiest way to test this out locally is to force all location searches to return as if there had been no results, eg, by updating the
determine_location_from_pc
function inLocation.pm
so that it returns early like this: