fix using multiple disable messages on category questions #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3186 +/- ##
=======================================
Coverage 83.65% 83.66%
=======================================
Files 251 251
Lines 15742 15744 +2
Branches 2943 2942 -1
=======================================
+ Hits 13169 13172 +3
Misses 1639 1639
+ Partials 934 933 -1
Continue to review full report at Codecov.
|
struan
force-pushed
the
issues/commercial/1997-incorrect-disabled-messages
branch
from
06581c4
to
75c205f
Compare
dracos
approved these changes
Sep 24, 2020
| $category{$message} ||= {}; | ||
| $category{$message}->{message} = $message; | ||
| $category{$message}->{code} = $_->{code}; | ||
| push @{$category{$message}->{answers}}, $opt->{key}; |
There was a problem hiding this comment.
Took me a little while, but I see how this works now, nice.
Provide a stopper per disable message, rather than per question. Previously there was one stopper per dropdown so only the last message encountered was used.
struan
force-pushed
the
issues/commercial/1997-incorrect-disabled-messages
branch
from
75c205f
to
6aece0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a stopper per disable message, rather than per question
Fixes https://github.com/mysociety/fixmystreet-commercial/issues/1997