Fix email alert on initial update template. #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3209 +/- ##
=======================================
Coverage 83.80% 83.80%
=======================================
Files 249 249
Lines 15803 15803
Branches 2970 2970
=======================================
Hits 13243 13243
Misses 1621 1621
Partials 939 939
Continue to review full report at Codecov.
|
struan
approved these changes
Oct 8, 2020
| @@ -1736,7 +1736,7 @@ sub create_related_things : Private { | |||
| my $request = { | |||
| service_request_id => $problem->id, | |||
| update_id => 'auto-internal', | |||
| comment_time => DateTime->now, | |||
| comment_time => DateTime->now->add( seconds => 1 ), | |||
There was a problem hiding this comment.
I think a comment to indicate what's going on here would be helpful.
A report's confirmation timestamp uses current_timestamp, and so includes microseconds. An initial update text, to fit in with the Open311 handling of updates, uses a DateTime object, which does not. This means if a report is created when logged in, the initial update can have a timestamp earlier than the report, and so is not alerted on.
dracos
force-pushed
the
fix-first-comment-timestamp
branch
from
9296c6a
to
2d87d6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A report's confirmation timestamp uses current_timestamp, and so
includes microseconds. An initial update text, to fit in with the
Open311 handling of updates, uses a DateTime object, which does not.
This means if a report is created when logged in, the initial update
can have a timestamp earlier than the report, and so is not alerted on.