prevent editing of category names with hardcoded flag #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struan
force-pushed
the
issues/commercial/1992-hardcoded-category-protection
branch
from
a15907f
to
bfce60e
Compare
struan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3227 +/- ##
==========================================
+ Coverage 83.88% 83.89% +0.01%
==========================================
Files 251 251
Lines 15944 15949 +5
Branches 3002 3005 +3
==========================================
+ Hits 13374 13381 +7
Misses 1620 1620
+ Partials 950 948 -2
Continue to review full report at Codecov.
|
davea
requested changes
Oct 26, 2020
| @@ -276,7 +276,7 @@ sub update_contact : Private { | |||
| $contact->send_method( $c->get_param('send_method') ); | |||
|
|
|||
| # Set flags in extra to the appropriate values | |||
| foreach (qw(photo_required open311_protect updates_disallowed reopening_disallowed assigned_users_only anonymous_allowed)) { | |||
| foreach (qw(photo_required open311_protect updates_disallowed reopening_disallowed assigned_users_only anonymous_allowed hardcoded)) { | |||
There was a problem hiding this comment.
I suppose it doesn't really matter, because this page is already behind a staff-only login, but there should be a superuser check here too (like the one in the template) rather than trusting input from the client.
struan
force-pushed
the
issues/commercial/1992-hardcoded-category-protection
branch
from
e5cc983
to
6f6a65c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a category has hardcoded set to 1 in it's extra metadata then prevent
the name being edited in the admin. This is to avoid issues where the
name of the category is used in e.g. layers or other configuration and
changing it breaks things.
Also includes admin interface for setting this that is restricted to
super users only.
Fixes mysociety/fixmystreet-commercial#1992